philc / philc/vimium

Mapping 'go to mark' key stops marks from working

Open
#2,497 1 comment 8 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

On Vivaldi browser, custom keymap:

# I prefer ' than ` for go to mark
map ' Marks.activateGotoMode

results in mark creation appearing not to work; 'go to mark' results in no action.

On the other hand, defining the 'create mark' key again results in everything ok, including both 'go to' keys working.

# I prefer '  than ` for go to mark
map m Marks.activateCreateMode       #  same as the existing mapping
map ' Marks.activateGotoMode             #  ` still works too

No big deal, only reporting it for completeness sake and for anyone googling.

Great extension, thanks for it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the custom keymap in Vivaldi: map ' to Marks.activateGotoMode and verify whether mark creation and both go-to-mark keys work. Compare this with the configuration that also remaps Marks.activateCreateMode; done means identifying and correcting the behavior without breaking either key mapping.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.