philc / philc/vimium

Questions about the handler stack

Open
#2,491 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

I'm just wondering about the wisdom behind it. I've stared at the Vimium codebase probably more than anyone who isn't a core contributor, and I can't wrap my head around it.

What are its advantages? I'm implementing my own extension like Vimium, and I use a simple state machine, and it seems to work fine, which scares me. I feel like I'm overlooking some detail that will come back to haunt me. I've implemented Command, Text, and Hints modes. Is there something about the other modes, or some particular feature that necessitates the control flow provided by the handler stack?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

This issue asks for an architectural explanation of Vimium's handler stack and how it relates to the Command, Text, Hints, and other modes. Trace the handler-stack entry point and mode transitions, then document its advantages, the details a simple state machine may miss, and which features require the existing control flow.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Documentation
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
15/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.