philc / philc/vimium

Vertically center link hints within client rect

Open Beginner friendly
#2,485 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

Link hints vertically centered within the bounding rectangle of the element they refer to look more natural to me.

The implementation is simple:

  • set the top of the link hint to the top of the bounding rectangle + half the bounding rectangle height
  • apply the style: transform: translateY(-50%)

New:

screen shot 2017-04-20 at 4 19 55 pm

Old:

screen shot 2017-04-20 at 4 19 20 pm

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the code that positions link hints relative to an element's bounding rectangle. Adjust the vertical position and styling as described, then verify that hints are vertically centered within their target rectangles and that the displayed result matches the new screenshot.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
62/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.