philc / philc/vimium

Following multiple links changes hint chars after each hit

Open
#2,462 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

The problem

When following multiple links via Alt+f command hint characters change after opening every single link.

Steps to reproduce

  1. Go to https://github.com/notifications
  2. Press Alt+f to enter mode for following multiple links
  3. Type hint characters for one of the notifications

Observed behavior

The hint characters randomly change.

Expected behavior

The hint characters remain unchanged after opening a link.

Gif with the issue happening

peek 2017-03-30 22-46

Affected website

GitHub notifications page

Observations

I think that this issue is caused by the "mark as read" button disappearing but IMO it would be better if the link characters stayed unchanged for the whole duration of the mode. That way the users can read them only once and quickly follow multiple links.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue on the GitHub notifications page by entering multiple-link mode with Alt+f and opening a notification link. Trace the hint-generation behavior around the disappearing “mark as read” button; done means hint characters remain unchanged throughout the mode.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.