philc / philc/vimium

Hebrew related issue

Open
#2,183 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

A certain new issue has risen while using Hebrew in the "Open a link in the current tab" feature.
This is a new issue and probably caused by June 12's version.

Before this update, after pressing the "f" key, And seeing the highlighted links with their respective shortcuts, Pressing the same key as the English character in Hebrew resulted in maneuvering to the wanted page.

E.g. : After pressing the "f" button, A certain link would show up, Let's say the link we want to navigate to is marked "a".
Before the update, Pressing the hebrew key ש which sits on the same key, Would navigate to the wanted link.

Where as now, IT just closes the navigate pane.

This bug is quite critical for us users with foreign links, And is very problematic.

It is important to note that this is NOT related to https://github.com/philc/vimium/issues/279
As the hebrew keymaps still work fine, only the specific feature for the "Open a link in the current/new tab".

My guess is that it was switched from reading a certain key, to a certain charcter

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue in Vimium's "Open a link in the current tab" flow with a Hebrew keyboard layout, then trace the keyboard handling for link hints. Done means that pressing the Hebrew key corresponding to a displayed English shortcut opens the intended link without closing the navigation pane.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.