philc / philc/vimium

Zoomed text, posible bug

Open
#2,159 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

I love your plugin, I'm having great time using it, but I've found a possible bug under OSX.

If I have a zoomed by the OS chrome window and I try to navigate by pressing f or F but the links at the screen wont have any "shortcut" letters to type.

This kind of zoom is done by double taping on the text, I think is called something like autozoom, or pinching with to fingers. All quite "iPhone style"

Taking a look at the code, the problem could be the calc of the visible area.

I know this is a particularly edge case, because vimium is thought to use the mouse/trackpad less, but I find my self reading large articles by this "zoom" method quite often.

Hope it helps, regards

Alvaro Pinot

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named in the report. Reproduce the Vimium link-navigation behavior in Chrome on OSX with OS-level text zoom enabled, then inspect the visible-area calculation mentioned in the issue. Done means shortcut letters appear on visible links and f/F navigation works while zoomed.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.