Punctuation is no longer a candidate for filtered link hints
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 27k
- Forks
- 2.6k
- PR merge metrics
- No merged PRs in 30d
Description
Thanks for your work. I'm a huge fan of Vimium.
With link-hint mode enabled, in an earlier version of Vimium, if a link consistent of punctuation, eg ", I could navigate to it by typing f + ". In Vimium 1.55, typing " after f has no effect.
This functionality may seem unimportant, as very few actual links consist of only punctuation. But its use is clearer if you consider that buttons are also links. In my case, I work with a webtool that has a whole slew of punctuation buttons: ", ', ;. I hope you'll consider reinstating the feature.
Versions:
- Google Chrome: 50.0.2661.102 (Official Build) (64-bit)
- Vimium: 1.55
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue in Vimium 1.55 with link-hint mode enabled and a link or button whose text is only punctuation. Trace the link-hint filtering behavior from that reproduction; done means punctuation characters can again be typed as candidates, including ", ' and ;.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100