Vimium disables/breaks `confirm` and `alert` on all pages
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 27k
- Forks
- 2.6k
- PR merge metrics
- No merged PRs in 30d
Description
I recently noticed that various pages weren't working for me as they should. I eventually tracked this down to window.confirm always returning false.
Steps to reproduce
- Create a new Chrome browser profile
- Install Vimium
- Open any web page and pop open the developer console
- Execute
confirm("check confirm?"); - Execute
alert("hello world!");
Expected behaviour
Steps 4. and 5. should both result in browser popups. confirm should return true or false depending on whether the user clicks 'OK' or 'Cancel' on the popup.
Observed behaviour
confirm(...) returns false immediately, without displaying a popup. alert similarly returns immediately, without displaying a popup.
Disabling Vimium doesn't immediately fix the issue, but a subsequent browser restart will. Reenabling Vimium causes the issue to recur.
Version details
Mac OS X 10.11.3 (15D21)
Chrome 51.0.2693.2 dev
Vimium 1.54
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No source file or test is named. Reproduce the issue using the listed Chrome and Vimium versions, including a browser restart, then trace how Vimium affects page-level alert and confirm calls. Done when both dialogs work normally with Vimium enabled and confirm returns the user's choice.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend, tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100