Vimium attempts to scroll the (non-scrollable) page instead of a scrollable frame when zoom > 100%
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 27k
- Forks
- 2.6k
- PR merge metrics
- No merged PRs in 30d
Description
For example, if you visit Google Groups with the browser zoom level set above 100% and hit j/k, Vimium mistakenly thinks the entire page is scrollable (actually, it appears to be scrollable by 1 pixel), so it attempts to scroll the whole page rather than the scrollable topics list in the main frame. However, if you reload the page with 100% zoom, j/k will correctly scroll the main frame instead of attempting to scroll the page.
VimFx in Firefox had a similar problem, as reported here, which was fixed via this commit. Perhaps Vimium could employ a similar strategy (i.e., don't consider the page scrollable unless scrollable by at least several px).
Note, VimFx also has a feature to focus scrollable divs via hints (when you hit "f" to generate link hints, it also adds hints to scrollable divs). This would be a useful addition to Vimium.
OS: Windows 8.1
Chrome version: 47.0.2526.111 (Official Build) m (32-bit)
Vimium version: 1.53
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the Google Groups case in Chrome with zoom above 100% and j/k, then trace the scroll-target selection used for keyboard scrolling. Compare the behavior at 100% zoom and verify that a page with only about 1 pixel of scroll range is skipped in favor of the scrollable frame.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100