philc / philc/vimium

Next/previous shortcuts cause annoying page scroll

Open
#1,909 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

When I press [[ or ]], the page usually scrolls down a bit, even if the "Previous" or "Next" text was already in the viewport.

To reproduce: go to http://abstrusegoose.com/570, increase zoom to around 150% (large enough so that the page doesn't fit in a single frame, and the scrollbar appears), and then hit [[ or ]].

What might be causing this? How could I fix this?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue at abstrusegoose.com/570 with zoom around 150%, then press [[ and ]]. Trace the next/previous shortcut handling and its interaction with page scrolling. Done means the shortcut changes pages without scrolling when the Previous or Next link is already visible.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.