philc / philc/vimium

Regex search doesn't work well with <input> text boxes

Open
#1,118 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
27k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

For example, regex search misbehaves on this page because of the <input> boxes.

This happens since window.find matches text in <input> boxes, but the box's contents aren't included in document.body.innerText, on which the actual Regex matching is done.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked reproduction page and compare window.find results with document.body.innerText when searching the input boxes. Then trace the regex search entry point that performs the matching. Done means regex searches handle text inside input elements consistently with the visible page content.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.