phetsims / phetsims/wave-interference

Enable clipping for WebGL

Open
#331 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

priority:5-deferred type:performance
Dominant language
TypeScript
Stars
20
Forks
12
PR merge metrics
No merged PRs in 30d

Description

In https://github.com/phetsims/wave-interference/issues/322 we added a WebGL layer to attain reasonable performance, but to avoid complication, we omitted the clip area. This should be restored (not for 1.0).

UPDATE: see in particular this comment https://github.com/phetsims/wave-interference/issues/322#issuecomment-457769739

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading issue 322 and the linked comment, then inspect the WebGL layer in the wave-interference project to locate where clipping was omitted. Done means the WebGL rendering respects the clip area without compromising the existing performance goal.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.