phetsims / phetsims/chipper

Sabotaging a key does not fail `grunt modulify --targets=strings`

Open
#1,603 1 comment 0 reactions 1 assignee View on GitHub

Nobody has claimed this yet.

status:ready-for-review
Dominant language
TypeScript
Stars
17
Forks
20
PR merge metrics
No merged PRs in 30d

Description

Sabotaging a key does not fail grunt modulify --targets=strings

For instance,

  soluteConcentrationsAccordionBox:
    accessibleParagraph: A barchart for each solute captures amounts on either side of membrane, recent crossings captured with visual highlights and sounds. If needed, pause sim to freeze details for reading.
    barChart:
      accessibleName: "{ a11y.solute }: { a11y.soluteConcentrationsAccordionBox.barChart.comparison } { a11y.soluteConcentrationsAccordionBox.barChart.crossing }."
      comparison:     |-
                      { $amount ->
                        [aLittleMore]  A little more
                        [aLotMore]     A lot more
                        [aLittleLess]  A little less
                        *[aLotLess]     A lot less
                      } outside than inside
      crossing:       |-
                      { $crossing ->
                        *[none] no crossings
                        [inside] crossings in
                        [outside] crossings out
                        [both] crossings in and out
                      }

is correct, but if adjusted to:


  soluteConcentrationsAccordionBox:
    accessibleParagraph: A barchart for each solute captures amounts on either side of membrane, recent crossings captured with visual highlights and sounds. If needed, pause sim to freeze details for reading.
    barChart:
      accessibleName: "{ a11y.solute }: { a11y.HELLOWORLD.barChart.comparison } { a11y.soluteConcentrationsAccordionBox.barChart.crossing }."
      comparison:     |-
                      { $amount ->
                        [aLittleMore]  A little more
                        [aLotMore]     A lot more
                        [aLittleLess]  A little less
                        *[aLotLess]     A lot less
                      } outside than inside
      crossing:       |-
                      { $crossing ->
                        *[none] no crossings
                        [inside] crossings in
                        [outside] crossings out
                        [both] crossings in and out
                      }

It should fail, but does not fail.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.