phetsims / phetsims/chipper

Generating API files causes unexpected babel work in unrelated repos

Open
#1,439 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
17
Forks
20
PR merge metrics
No merged PRs in 30d

Description

While regenerating the API for Projectile Data Lab, @samreid and I encountered the following console errors in WebStorm:

matthewblackman@Matthews-MacBook-Pro-2 projectile-data-lab % grunt generate-phet-io-api 
Running "generate-phet-io-api" task
[BABEL] Note: The code generator has deoptimised the styling of /Users/matthewblackman/Documents/PhET/phetsims/balloons-and-static-electricity/images/sweater_png.ts as it exceeds the max of 500KB.
[BABEL] Note: The code generator has deoptimised the styling of /Users/matthewblackman/Documents/PhET/phetsims/build-a-molecule/js/common/model/data/otherMoleculesData.js as it exceeds the max of 500KB.
[BABEL] Note: The code generator has deoptimised the styling of /Users/matthewblackman/Documents/PhET/phetsims/build-a-molecule/js/common/model/data/structuresData.js as it exceeds the max of 500KB.
[BABEL] Note: The code generator has deoptimised the styling of /Users/matthewblackman/Documents/PhET/phetsims/density-buoyancy-common/images/Metal002_col_jpg.ts as it exceeds the max of 500KB.
[BABEL] Note: The code generator has deoptimised the styling of /Users/matthewblackman/Documents/PhET/phetsims/density-buoyancy-common/images/Metal002_nrm_jpg.ts as it exceeds the max of 500KB.
[BABEL] Note: The code generator has deoptimised the styling of /Users/matthewblackman/Documents/PhET/phetsims/density-buoyancy-common/images/Metal002_rgh_jpg.ts as it exceeds the max of 500KB.
[BABEL] Note: The code generator has deoptimised the styling of /Users/matthewblackman/Documents/PhET/phetsims/density-buoyancy-common/images/Metal007_col_jpg.ts as it exceeds the max of 500KB.
[BABEL] Note: The code generator has deoptimised the styling of /Users/matthewblackman/Documents/PhET/phetsims/density-buoyancy-common/images/Metal007_nrm_jpg.ts as it exceeds the max of 500KB.
[BABEL] Note: The code generator has deoptimised the styling of /Users/matthewblackman/Documents/PhET/phetsims/density-buoyancy-common/images/Metal007_rgh_jpg.ts as it exceeds the max of 500KB.
[BABEL] Note: The code generator has deoptimised the styling of /Users/matthewblackman/Documents/PhET/phetsims/density-buoyancy-common/images/Plastic018B_col_jpg.ts as it exceeds the max of 500KB.
[BABEL] Note: The code generator has deoptimised the styling of /Users/matthewblackman/Documents/PhET/phetsims/density-buoyancy-common/images/Plastic018B_nrm_jpg.ts as it exceeds the max of 500KB.
[BABEL] Note: The code generator has deoptimised the styling of /Users/matthewblackman/Documents/PhET/phetsims/density-buoyancy-common/images/Plastic018B_rgh_jpg.ts as it exceeds the max of 500KB.

We aren't sure why running grunt generate-phet-io-api from the projectile-data-lab repo would trigger this Babel work, and would like to investigate further.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing grunt generate-phet-io-api from the projectile-data-lab repository and trace the generate-phet-io-api task in chipper. Determine why Babel processes files from unrelated repositories such as balloons-and-static-electricity and build-a-molecule; done means the command no longer performs unexpected work outside its intended project.

Written by the indexing model from the issue text.

Assessment

Tech stack
babel, typescript
Domain
build-system, tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.