Address some potential bugs in translations
Nobody has claimed this yet.
- Dominant language
- Fluent
- Stars
- 6
- Forks
- 12
- PR merge metrics
- No merged PRs in 30d
Description
Over in https://github.com/phetsims/number-play/issues/226, QA reported some spots that seemed pretty obvious to be a mistake. For example, where a parenthesis is opened but not closed, or there is a third template var curly brace. We spoke to @jbphet and he mentioned that just manually fixing these, if we feel very very confident of translator error, is totally fine.
So we did https://github.com/phetsims/babel/commit/98db64e43d8dc8b6c8c02d16c6b4c835b0c156f4
From that there are a couple of questions more generally (note that by searching in _generated_development_strings you don't search through history, and just current values of strings):
- 2 usages
{{{ - 2 usage of
}}} - 86 usages of
".*\([^)\n]*"(match an open paren that isn't closed), though we need to be careful about rtl languages here - 24 usages of
"[^(\n]*\).*"(match a closed paren without an open), again worry about rtl languages and manually inspect things
@jbphet, does this seem like a worth while investigation?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.