phan / phan/phan

Redundant Condition Detection doesn't account for initial 'unset' state from `!isset($this->y)`

Open
#4,720 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement redundant condition detection
Dominant language
PHP
Stars
5.6k
Forks
365
Avg merge
1h 25m
Merged PRs (30d)
6

Description

Code Snippet: https://3v4l.org/lEbfg (full code also provided at end of issue)
Phan version used: 5.4.1
Observed behavior:

test.php:10 PhanRedundantCondition Redundant attempt to cast $this->y of type string to isset

Expected behavior: No errors (in the real world case, then $this->y might or might not be set based on a more complex set of ifs in the constructor, and the property is readonly; so I can't set it at the top of the function and then set it to a different value later.

Full test code:

<?php
class y{
	public string $y;
	
	public function __construct(bool $b){
		if($b){
			$this->y = "hello";
		}
		
		if(!isset($this->y)){
			$this->y = "goodbye";
		}
	}
}

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the report using the full PHP example in the issue or the linked 3v4l.org snippet with Phan 5.4.1. Start by tracing the redundant-condition analysis that emits PhanRedundantCondition for the isset check; done means the valid initial unset state no longer produces that warning.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
devtools
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.