Warn about `catch (... $e) { throw $e; }` in DuplicateExpressionPlugin
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- PHP
- Stars
- 5.6k
- Forks
- 365
- Avg merge
- 1h 25m
- Merged PRs (30d)
- 6
Description
This is generally left over code from code which used to log an exception - it creates a local variable that is usually not used and is less efficient.
Do not warn if there are catch statements after it.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with DuplicateExpressionPlugin and trace how it handles catch statements. Add a warning for catch (... $e) { throw $e; }, while preserving cases with later catch statements; done means the analyzer reports only the specified redundant pattern without false positives.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- devtools
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100