Plugin idea: Warn about conditions `A && B` where B implies A
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- PHP
- Stars
- 5.6k
- Forks
- 365
- Avg merge
- 1h 25m
- Merged PRs (30d)
- 6
Description
<?php
if (!is_object($a) && is_string($a)) {
// ...
}
if ($a && $a === true) {
}
Currently, phan only warns when A makes B redundant, not the other way around.
Possibly check if the implied types are subsumed by B's implied types
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the existing warning for conditions where A makes B redundant and review how implied types are compared. Extend the analysis to detect when B's implied types subsume A's, covering examples such as !is_object($a) && is_string($a) and $a && $a === true; done means these reverse-redundancy cases are warned about without new false positives.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- devtools
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100