phan / phan/phan

Use reasonable parameter defaults in stubs generated by `tool/make_stubs`

Open
#3,721 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
PHP
Stars
5.6k
Forks
365
Avg merge
1h 25m
Merged PRs (30d)
6

Description

e.g. for json_encode(), = null should not be emitted. Instead, = 0 should be emitted for non-nullable union types containing int, etc

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with tool/make_stubs and inspect how defaults are selected for json_encode() and non-nullable union types. Compare generated signatures with the intended parameter types; done means nullable defaults such as null are replaced with compatible scalar defaults, such as 0 for unions containing int.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.