Make NegatedConditionVisitor also call BlockAnalysisVisitor->visitCall to analyze (!A && B)
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- PHP
- Stars
- 5.6k
- Forks
- 365
- Avg merge
- 1h 25m
- Merged PRs (30d)
- 6
Description
Observed: PhanTypeMismatchArgumentNullable
Expected: No warnings
function any() : ?array {
return ['abc'];
}
function expects_array(array $x) {
return true;
}
if (!is_null($x = any()) && expects_array($x)) {
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate NegatedConditionVisitor and BlockAnalysisVisitor::visitCall in the analyzer, then reproduce the issue with the provided nullable-array example. Trace how the condition is analyzed and verify that the example produces no PhanTypeMismatchArgumentNullable warning when the fix is complete.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100