Phan should infer that `null != '0'`, `'' != []` for truthiness checks
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- PHP
- Stars
- 5.6k
- Forks
- 365
- Avg merge
- 1h 25m
- Merged PRs (30d)
- 6
Description
Currently, phan infers that null != $x or '' != $x means that $x is truthy. This is the most important exception to that.
Include '0' and [] in the resulting type sets (etc.) according to the below table
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing Phan's truthiness inference for comparisons such as null != $x and '' != $x, using PHP's type-comparison table as the behavioral reference. Update the resulting type sets to account for '0' and []; done means these cases are no longer treated as universally truthy and the relevant comparison behavior is covered.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100