phan / phan/phan

Infer that some methods invalidate known types for properties of $this

Open
#3,292 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
PHP
Stars
5.6k
Forks
365
Avg merge
1h 25m
Merged PRs (30d)
6

Description

Related to #3211

e.g. if __construct calls $this->_init(), and _init sets the value of $this->prop, then either clear the known types for the property or set types to the new type (if nearly certain that that will be the new value).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading related issue #3211 and tracing how Phan tracks known types for properties of $this across method calls. Check the handling of __construct calling _init and determine the evidence needed to clear or update the property's known type; done when the intended invalidation or inference behavior is covered for this case.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
devtools
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.