Plugin idea: Warn about adjacent assignment statements from same pure function/method with the same args
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- PHP
- Stars
- 5.6k
- Forks
- 365
- Avg merge
- 1h 25m
- Merged PRs (30d)
- 6
Description
$i = strlen($s1);
$j = strlen($s1);
/// ...
// for ArrayObject, etc.
$len1 = $a1->count();
$len2 = $a1->count();
Check that args aren't part of the assignment target
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file, test, or entry point is named. Start by locating Phan's plugin and assignment-analysis infrastructure, then review how pure functions and methods are identified. Done means reporting adjacent repeated calls with the same arguments while excluding arguments that are part of the assignment target, as in the provided PHP examples.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- devtools
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100