Add tests that canCastToDeclaredType is consistent with real implementation
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- PHP
- Stars
- 5.6k
- Forks
- 365
- Avg merge
- 1h 25m
- Merged PRs (30d)
- 6
Description
// with and without strict_types
function accepts_int(int $arg) {
}
accepts_int(STDIN);
accepts_int(null);
Verify that if a TypeError is thrown when that is passed in, then Phan would be able to tell that the corresponding Type->canCastToDeclaredType() is false.
Do this for literals, regular types, etc., comparing to types allowed in declarations
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating Type->canCastToDeclaredType() and the existing type-related tests. Exercise accepts_int() with and without strict_types, using literals and regular types, and compare Phan's result with whether PHP throws TypeError. Done means the tests cover the requested declaration cases and consistently match the real implementation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- devtools, testing
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100