Phan fails to emit RedundantCondition when a parameter is in a method overriding another method
Open
Nobody has claimed this yet.
enhancement
redundant condition detection
- Dominant language
- PHP
- Stars
- 5.6k
- Forks
- 365
- Avg merge
- 1h 25m
- Merged PRs (30d)
- 6
Description
Seen in StaticType::isExclusivelyNarrowedFormOrEquivalentTo for CodeBase $code_base
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in StaticType::isExclusivelyNarrowedFormOrEquivalentTo and inspect how CodeBase $code_base handles parameters in overriding methods. Reproduce the case described in the issue and trace why RedundantCondition is not emitted. Done means the analyzer reports the expected RedundantCondition without introducing false positives.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100