phan / phan/phan

Warn about catch(Exception $e) { throw $e; } being a no-op ...

Open
#2,599 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

dead code detection enhancement
Dominant language
PHP
Stars
5.6k
Forks
365
Avg merge
1h 25m
Merged PRs (30d)
6

Description

Only warn about the last catch block(s). Don't warn if they prevent subsequent catch statements from being reached.

Do that if the catch block has a single non-comment statement. Mention that the only effect is creating $e

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files or tests. Start by locating the catch-block analysis and its existing warning tests, then verify how later catch blocks are determined to be reachable. Done means warnings cover only the final applicable catch block or blocks with a single non-comment statement and explain that the only effect is creating $e.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
devtools
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.