Assertions such as `get_class($x) === 'stdClass'` should expect case sensitive namespace+class
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- PHP
- Stars
- 5.6k
- Forks
- 365
- Avg merge
- 1h 25m
- Merged PRs (30d)
- 6
Description
E.g. phan should warn about assert(get_class($a) === 'STDCLASS')
Starting to track the case-sensitive namespace and name in Phan\Language\Element\Clazz separately from the FQSEN of the first reference will help
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading Phan\Language\Element\Clazz and the code that analyzes assertions involving get_class(). Trace how the namespace and class name are currently represented, then verify that a comparison such as get_class($a) === 'STDCLASS' produces the expected warning.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100