phan / phan/phan

"Go to definition" (in LSP) should also look for classes, functions for a class constant

Open
#1,922 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement language server
Dominant language
PHP
Stars
5.6k
Forks
365
Avg merge
1h 25m
Merged PRs (30d)
6

Description

E.g. $x = MyClass is normally treated like a global constant MyClass.

If a user hasn't finished typing the line, it's possible that it is referring to a function or global constant.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the LSP "Go to definition" implementation and its existing tests, then trace how a class constant reference is resolved. Verify behavior for an incomplete $x = MyClass expression by checking whether matching classes, functions, and global constants are offered as definition targets.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
devtools
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.