Self-analysis plugin idea: Infer shape type of `ast\Node->children` based on `ast\Node->kind === ast\AST_*`
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 5.6k
- Forks
- 365
- Avg merge
- 1h 25m
- Merged PRs (30d)
- 6
Description
This would help cut down on the false positives for self-analysis
Currently, there's no way to hook into a condition visitor. There's also no way to override property types in the local scope, yet.
Also, visitArray(Node $node) should make Phan know (from the method name) that the $node->children is an array of null/Nodes (AST_ARRAY_ELEM), etc.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the self-analysis logic around condition visitors and the visitArray(Node $node) entry point, then inspect how ast\Node->children, ast\Node->kind, and AST_* values are currently typed. The issue describes several related capabilities but names no files or tests; completion would require defining and implementing the intended inference behavior while reducing the reported false positives.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- devtools
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100