phalcon / phalcon/cphalcon

[NFR]: Change return type of `Phalcon\Collection:getIterator()` to `ArrayIterator`

Open
#15,714 1 comment 0 reactions 1 assignee View on GitHub

@Jeckerson is already working on this.

Since Oct 11, 2021.

7.0 breaks bc external dependency new feature request
Dominant language
PHP
Stars
10.8k
Forks
1.9k
Avg merge
7h 2m
Merged PRs (30d)
47

Description

Current Traversable interface does not has any methods signatures, which is not practical in terms of autocomplete of methods and for static code analysers.

https://github.com/phalcon/cphalcon/blob/645cf382358b96cbe9659f6634f41c940e89a7e4/phalcon/Collection.zep#L147

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.