pgadmin-org / pgadmin-org/pgadmin4

Permission to disable Change password dialog (for PostgreSQL)

Open
#9,230 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Housekeeping
Dominant language
Python
Stars
3.8k
Forks
891
Avg merge
4d 7h
Merged PRs (30d)
8

Description

Describe the solution you'd like

Some pgAdmin users confuse current Change Password... dialog for PostgreSQL user. They think that they are changing password for their pgAdmin account.

Image

I know that they can still change PostgreSQL password though SQL, but it would be great to be able to disable this dialog so it is not confused with a password of pgAdmin account.

Describe alternatives you've considered

Alternatively, the dialog could be automatically disabled for all non-owner users if "Shared Username" is set on the server. It would be only available to server object owner. Just not sure if that would be not too confusing.

Additional context

The problem is more serious in environment where Server list is predefined, is setup to use pgpassfile, and is shared. Unknowingly any user could change PostgreSQL password through mentioned dialog, and all other users won't be able to login.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the Change password dialog and the server settings handling Shared Username and pgpassfile; start by tracing how ownership and password changes are currently determined. Clarify whether the feature should hide or disable the dialog for non-owners or provide an explicit permission, with done meaning shared-server users cannot unintentionally change the PostgreSQL password.

Written by the indexing model from the issue text.

Assessment

Tech stack
postgresql, python
Domain
databases, security
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.