pgadmin-org / pgadmin-org/pgadmin4
Select all rows in results grid should allow copy
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 3.8k
- Forks
- 891
- Avg merge
- 4d 7h
- Merged PRs (30d)
- 8
Description
Describe the bug
Assuming I have a result set with more than the configured "Data result rows per page", I click the upper left corner of the grid to select all rows. This selects just the rows in the batch, but offers a button labeled "Select All N Rows". If I click that button, a message is shown stating "All N rows are selected". However, the Copy button is disabled, so I can't actually copy the rows.
To Reproduce
Steps to reproduce the behavior:
- Rows per page is set to 1000
- I run a query that has 24945 results
- Click on the empty space above the row numbers to select all rows
- Click on the button labeled "Select All 24945 Rows"
Expected behavior
Copy button should be enabled, allowing me to copy these rows.
Screenshots
Desktop (please complete the following information):
- OS: Windows-11-10.0.22631-SP0
- Version: 8.13
- Mode: Desktop
Additional context
My employer manages our PGAdmin install. Not sure what version I had previously but it didn't have this paging system. In that version, I could just click the space above the row numbers twice and the entire result set would be loaded.
I can work around this new issue by editing the range but I find this less convenient than the way it worked before.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No source file or test is named. Reproduce the issue with 1,000 rows per page and 24,945 query results, then trace the results grid's select-all and Copy-button state; done means selecting all rows enables Copy and allows the full result set to be copied.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- postgresql, python
- Domain
- databases, frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100