pgadmin-org / pgadmin-org/pgadmin4
Please add a keyboard shortcut (Ctrl + Enter) for saving and closing the sort/filter dialog
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 3.8k
- Forks
- 891
- Avg merge
- 4d 7h
- Merged PRs (30d)
- 8
Description
Describe the solution you'd like
I would love a way to save and close the sort/filter dialog without having to use the mouse cursor. I usually try to hit just the Enter key but that creates a newline in the filter input field.
The sort/filter dialog can be opened with a keyboard shortcut, so we should also be able to save and close it with a keyboard shortcut too.
On Windows/Linux the shortcut that would work the best is probably Ctrl+Enter. On macOS the equivalent shortcut would be Cmd+Enter.
There are probably more dialogs that would benefit from this, so if this could be a general way to save and close most dialogs, that would be great.
Describe alternatives you've considered
N/A
Additional context
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No source file or test is named in the issue. Start by locating the sort/filter dialog and the existing shortcut that opens it, then inspect how the dialog saves and closes. Done means Ctrl+Enter on Windows/Linux and Cmd+Enter on macOS save and close the dialog without inserting a newline.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100