pex-gl / pex-gl/pex-renderer

Reflection map prefiltering improvements

Open
#331 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

scope/pbr type/fix
Dominant language
JavaScript
Stars
248
Forks
18
Avg merge
1m
Merged PRs (30d)
1

Description

Current implementation suffers from two major issues:
a) due to lack of multiple scattering metals get darker and they get rougher - solved by bumping reflection color based on roughness
b) bright spots cause fireflies due to insufficient filtering - solved by sampling different mipmap levels

Both are described here https://bruop.github.io/ibl/

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the reflection-map prefiltering implementation and read the linked IBL explanation for the two reported problems. The work is done when rough metals no longer darken or become rougher and bright spots no longer produce fireflies through improved mipmap-level sampling.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
computer-graphics
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.