pex-gl / pex-gl/pex-math

Add mat4.multQuat

Open
#28 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type/feat
Dominant language
JavaScript
Stars
17
Forks
2
PR merge metrics
No merged PRs in 30d

Description

When creating modelMatrix from rotation in pex-renderer i'm missing the following function

  var tempMat4multQuatMat4 = mat4.create();
  function mat4multQuat(m, q) {
    mat4.fromQuat(tempMat4multQuatMat4, q);
    mat4.mult(m, tempMat4multQuatMat4);
    return m;
  }

Do you think it would be worth adding?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the mat4 implementation and the existing fromQuat and mult operations in this repository. Compare their APIs with the issue's proposed mat4multQuat helper, then determine where the new operation belongs and verify that multiplying a matrix by a quaternion-derived rotation produces the expected result.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
computer-graphics
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.