v2 P5: Complete attachment upload
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 36
- Forks
- 7
- Avg merge
- 4m
- Merged PRs (30d)
- 2
Description
Part of the v2 roadmap (pillar P5 — bug cleanup).
Attachment._upload_file() requests an upload bucket from Monzo but never actually uploads the file bytes — there is a literal # TODO upload file in the current code (monzo/endpoints/attachment.py). Implement the real multipart upload to Monzo's pre-signed URL so create_attachment() works end-to-end for local files, not just already-hosted URLs.
Breaking: no (bug fix; call signature may need minor adjustment)
Effort: M
Phase: rc
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in monzo/endpoints/attachment.py at Attachment._upload_file() and trace how create_attachment() obtains Monzo’s upload bucket and pre-signed URL. Replace the TODO path with the multipart upload for local file bytes, then verify that create_attachment() completes successfully for local files as well as hosted URLs.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- api, backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 58/100