@nunomaduro Composer is made in a way that the vendor directory can be renamed (for a reason or another). If this PR seems with a lot of "unrelated" changes ... okey. But is it possible po have pestphp get the vendor fir from composer just like the ComposerScripts of laravel does ?
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 11.7k
- Forks
- 538
- Avg merge
- 4d 11h
- Merged PRs (30d)
- 8
Description
@nunomaduro Composer is made in a way that the vendor directory can be renamed (for a reason or another). If this PR seems with a lot of "unrelated" changes ... okey. But is it possible po have pestphp get the vendor fir from composer just like the ComposerScripts of laravel does ?
The only changes i made by the way are contained in one block in the bin/pest file
I am sure you can do the same thing in a better way !
If I knew how to do it so that it can be accepted i would have
Thank you by advance again
Yassine
Originally posted by @emyassine in https://github.com/pestphp/pest/issues/1834#issuecomment-5296593233
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the changed block in bin/pest and compare it with Laravel's ComposerScripts approach to locating the vendor directory. Done means Pest obtains the vendor directory from Composer rather than assuming a fixed name.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- testing
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100