perftools / perftools/xhgui

change markers

Open
#17 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
JavaScript
Stars
1.7k
Forks
341
PR merge metrics
No merged PRs in 30d

Description

When making changes during profiling, it would be very nice to add a marker, so that you can easily see the distinction between a change and the previous state. The marker would simple be a vertical line in the graph, so that you could see how effective your changes were.

One possible way of doing this, would be to add an additional parameter to the _profile=1&_xhchange=1 query string, so that you don't have to click a button in the UI.

Now, if you wanted to label the change, maybe a the xhchange param could be a string with a label.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the profiling graph and the handling of the _profile=1&_xhchange=1 query string. Define how a change marker and optional label should appear, then verify that the graph shows a vertical marker distinguishing the changed state from the previous state.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend, performance
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.