pepkit / pepkit/peprs

When building from `SampleYAML`, the sample index column is not cast to `DataType::String` [potential BUG]

Open Beginner friendly
#44 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
3
Forks
0
Avg merge
1d 14h
Merged PRs (30d)
2

Description

When building from SampleYAML, the sample index column is not cast to DataType::String like the CSV path is. If the YAML parses the index column as a non-string type (e.g. numbers), later lookups like get_sample(name: &str) can fail due to a dtype mismatch. Consider applying the same .lazy().with_column(col(final_index.clone()).cast(DataType::String)).collect()? normalization used in the CSV branch.

                let df = resolve_yaml_to_dataframe(&yaml_path)?
                    .lazy()
                    .with_column(col(final_index.clone()).cast(DataType::String))
                    .collect()?;

Originally posted by @Copilot in https://github.com/khoroshevskyi/peprs/pull/43#discussion_r3104373679

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Find the code path that builds a dataframe from SampleYAML and compare it with the CSV branch, which already normalizes the index column. Apply the same index-string normalization shown in the issue, then verify that a numeric YAML index can be used by get_sample(name: &str).

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
data
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
78/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.