pepkit / pepkit/pephubclient

PEPhubclient should correctly handle domains for registry paths

Open
#48 5 comments 0 reactions 1 assignee View on GitHub

@khoroshevskyi is already working on this.

Since Aug 27, 2024.

bug
Dominant language
Python
Stars
3
Forks
0
PR merge metrics
No merged PRs in 30d

Description

If I make a looper config file with a weird, bogus registry path like this:

pep_config: bogus-website.com://databio/pep_derived_attrs:default
output_dir: results
pipeline_interfaces:
  - pipeline/pipeline_interface.yaml

It is actually ignoring the domain information, and just grabbing the databio/pep_derived_attrs:default section, and retrieving it from pephub, and running the pipeline correctly.

This means we're not handling the domain right. We're only allowing pephub.databio.org, regardless of what you put in the domain. This means we can't allow people to use this with a registry other than ours.

Instead, we can default to the main interface, but we need to allow the user to specify an alternative domain. What if I want to try this on a local instance, using localhost://registry_path? This is not currently possible.

Not sure if this is something to be fixed in looper or in PEPhubClient.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.