pepkit / pepkit/pephubclient

Create a session in the object to handle requests globaly

Open
#16 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Python
Stars
3
Forks
0
PR merge metrics
No merged PRs in 30d

Description

Another example of a class that might be able to be two functions. However, I think a requests manager could be useful. I've used this paradigm before. See here.

We can create a session in the object to handle things globally. I think this is a good example of such an object.

Originally posted by @nleroy917 in https://github.com/pepkit/pephubclient/pull/15#discussion_r1156569676

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the referenced lyricsgenius/api/base.py example, then inspect pephubclient's existing request-handling code to identify the object that should own the session. Clarify the intended global session behavior and add or update tests for it; done means requests are handled consistently through that session.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.