pepkit / pepkit/eido

Eido fails to recognize integer type in PEP

Open
#80 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
5
Forks
6
PR merge metrics
No merged PRs in 30d

Description

I have this PEP: nleroy917/38e44dd0-c3df-418e-9256-d0824748901, and I have assigned it to this schema.

Snippet of PEP:
file_document_id file_type file_name file_format read_index file_size
096d3d77-a00e-42d8-a9a5-97c301c42872 sequence_file SRR12695067_R2.fastq.gz fastq.gz read2 7540543107
59ff90f6-4ded-4ad3-ba77-8ff6a06a85dd sequence_file SRR12695068_R2.fastq.gz fastq.gz read2 8367854671
be978666-f337-40d1-9287-299aad4f6014 sequence_file SRR12695067_R1.fastq.gz fastq.gz read1 7537744821
de5d4175-d85c-4dc1-945c-19718fd3a0ae sequence_file SRR12695068_R1.fastq.gz fastq.gz read1 8349553318
Snippet of schema:
properties:
  samples:
    items:
      properties:
        file_size:
          type: integer

I get the following eido result:

{
  "valid": false,
  "error_type": "Samples",
  "errors": [
    "'7540543107' is not of type 'integer' (06de2327-26ba-44d4-8c03-b2c606e83ae1)",
    "'8367854671' is not of type 'integer' (299cb4fe-1697-4376-8670-b01afa252a33)",
    "'7537744821' is not of type 'integer' (13bad80f-a7a4-45e5-978a-f483d51169b8)",
    "'8349553318' is not of type 'integer' (a56225f5-d2ad-4bea-9d3e-c6bf2dcbace5)"
  ]
}

It seems like it just sends it as a string, but it **is** a valid integer.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the reported validation with the linked PEP and schema snippets, then trace how the table's file_size values are converted before schema validation. No repository file or test is named in the issue; done means integer file_size values validate against the declared integer schema type.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.