pendulum-chain / pendulum-chain/vortex

Bug - Second wallet connection to existing Monerium account.

Open
#890 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type:bug
Dominant language
TypeScript
Stars
6
Forks
5
Avg merge
1d 7h
Merged PRs (30d)
33

Description

Summary

Currently, a user that has successfully gone through the Monerium flow once, cannot register another wallet to the same Monerium account, and the app will fail without proper handling this case.

Detailed explanation

Since we cannot detect a user that has already done the Monerium KYC only by it's address, nor can we know the account that the user will use during the authentication, we cannot prevent a user attempting to connect a second address to our app.

From the user's perspective, the flow will go similarly to the first time only without any kyc data asked, and the flow will be "successful". On the subsequent register step, the backend won't be able to find the IBAN associated with the newly connected wallet, and the app will crash.

The root cause of this issue, is that only one IBAN can be associated with one person by default.

This issue is related to this ticket.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the second-wallet Monerium flow and trace the subsequent register step, where the issue says the backend cannot find the IBAN. Review related issue #884 for context. Done means a second wallet attempt is handled without the app crashing, with an appropriate outcome for the missing IBAN case.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
api, backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.