pendulum-chain / pendulum-chain/vortex

Improve gas amount derivation for 'squidRouterPay' phase

Open
#737 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
6
Forks
5
Avg merge
1d 7h
Merged PRs (30d)
33

Description

Context

It sometimes happens that Vortex is charging the squidrouter transaction for onramps with not enough gas. It's not clear why it's not enough as the squidRouterPay phase is actually getting the gas information directly from the axelar endpoint, but there has to be something we are missing.

In cases where not enough was charged by Vortex, manually adding the gas in the Axelar UI works. This means, the Axelar UI has the right means to derive the missing gas amount. The following code links should help understand how they derive the exact gas required in their UI.

  • The implementation of the function that is called when clicking on the 'Add gas' button is here.
  • That implementation is using a class from their axelarjs-sdk, namely the AxelarGMPRecoveryApi

TODO

Look through the code and adjust the logic of the squidRouterPay phase to use a similar derivation for the required gas.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the squidRouterPay phase and compare its gas derivation with the Axelar UI implementation in GMP.jsx and AxelarGMPRecoveryAPI.ts. Trace how the phase obtains gas from the Axelar endpoint, then confirm that it derives the required amount consistently with the linked recovery API so the Axelar UI does not require additional gas.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
backend-api-design
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.