pendulum-chain / pendulum-chain/vortex

Revert splitting of Moonbeam receiver contract

Open
#185 9 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
6
Forks
5
Avg merge
1d 7h
Merged PRs (30d)
33

Description

Context

To work around issues introduced by the increase in gas cost on Moonbeam, the receiver contract was split into two parts for https://github.com/pendulum-chain/vortex/issues/137, resulting in additional overhead on the frontend application.

It seems like squidrouter managed to deploy a fix that works around this issue and the original logic would work again. To reduce the overhead, the splitting of the receiver contract should get reverted.

TODO

  • Add changes to allow the execution with either the automatic forwarding or the split receiver contract. When re-adding the logic for the automatic forwarding, point to the old receiver contract 0x066d12e8f155c87a87d9db96eac0594e872c16b2, more info here.
  • Add a simple boolean flag to a config (either hardcoded or supplied via env variable) that defines which approach should be used.
  • Test that the 'old' logic works

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Trace the frontend application code that selects or invokes the split receiver contract, then inspect the configuration path used to choose deployment behavior. Compare that flow with the old receiver contract at 0x066d12e8f155c87a87d9db96eac0594e872c16b2. Done means a boolean configuration selects either automatic forwarding or the split contract, and tests confirm the old logic works.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
blockchain, frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.