pelias / pelias/spatial

investigate wof hierarchy discrepancy

Open
#33 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
32
Forks
8
Avg merge
13m
Merged PRs (30d)
1

Description

We have a report that https://spatial.demo.geocode.earth/explore/place/wof/85931121 is not showing the correct hierarchy.

The record shows a localadmin as parent which is not visible in the spatial database:
https://github.com/whosonfirst-data/whosonfirst-data-admin-us/blob/master/data/859/311/21/85931121.geojson

This may be related to a bug in the 'rank' algorithm in https://github.com/pelias/spatial/blob/master/import/source/whosonfirst/map/hierarchies.js

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare the hierarchy shown for WOF record 85931121 in the spatial demo with its GeoJSON record and the corresponding spatial database data. Start in import/source/whosonfirst/map/hierarchies.js, especially the rank algorithm, and determine why the localadmin parent is omitted. Done means the discrepancy's cause is identified and the hierarchy displays the expected parent.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
databases
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.