Potential superfluous classification in `classifier/scheme/street.js`
Open
Nobody has claimed this yet.
bug
- Dominant language
- JavaScript
- Stars
- 64
- Forks
- 26
- PR merge metrics
- No merged PRs in 30d
Description
Bug description
As discussed in https://github.com/pelias/parser/pull/195#pullrequestreview-3238761585 is seems the following classification is safe to remove in classifier/scheme/street.js:120:
not: ['IntersectionClassification']
Steps to reproduce
as discussed in https://github.com/pelias/parser/pull/195
Github references
No response
Environment
No response
Log output
Data references
No response
Project or organization
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open classifier/scheme/street.js around line 120 and review the classification rule discussed in pull request 195. Remove the not: ['IntersectionClassification'] entry if the surrounding rule still supports that change, then verify that street classification remains correct.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100