pelias / pelias/parser

Option to not use the WhosonFirstClassifier for AddressParser

Open
#173 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
JavaScript
Stars
64
Forks
26
PR merge metrics
No merged PRs in 30d

Description

pelias-parser has classifier called WhosonFirstClassifier to classify the token in the given address string as locality, region and country.

In our usecase, a lot of Norwegian street names are classified as a localities and regions.

For example:

Eikeland is classified as locality even if land is the valid street type in address Nordre Eikeland 50
Haga is classified as locality and bru is classified as region in address Haga bru 76

This results in pelias-api filtering out the address layer.

Solution

Solution may be to optionally not use the WhosonfirstClassifier.

Can we make optional using the configuration, like it is done for the admin unit lookup from Whos on First for data importers like pelias-csv-importer using the following configuration.

"imports": {
 "adminLookup": {
   "enabled": false
 },
},

We can add the configuration option in the pelias-config, which pelias-api can send further into pelias-parser using options parameter.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how pelias-api passes the options parameter into pelias-parser, then compare that path with the existing imports.adminLookup.enabled configuration in pelias-config. Inspect WhosonFirstClassifier and the parser entry point to determine where the option belongs. Done means the classifier can be disabled through configuration without breaking normal parsing, including the Norwegian examples described.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.