venue_classification: investigate change
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 64
- Forks
- 26
- PR merge metrics
- No merged PRs in 30d
Description
Today we are merging https://github.com/pelias/api/pull/1565 which brings a bunch of pelias/parser changes into pelias/api.
As part of this process we did some wider acceptance test checks and diff'd them against the current baseline.
One change which was identified was this query (at partial completion "San Simeon Drive Desert Hot Spr") which identifies the incomplete spr token as a street.
San Simeon Drive Desert Hot Springs CA 92240 {"focus.point.lat":33.96112,"focus.point.lon":-116.50168}
-FFFFF0000000000000000000000000000000000FFF00
+FFFFF0000000000000000000000000F00000000FFF00
Running a git bisect shows that this change was introduced in https://github.com/pelias/parser/commit/a65218d347b682da291ee16b6f84ddf4aba4827a
A simple change to the en/street_types.txt file seems to resolve the issue, but it's unclear why this issue didn't exist previously.
diff --git a/resources/pelias/dictionaries/libpostal/en/street_types.txt b/resources/pelias/dictionaries/libpostal/en/street_types.txt
index 30ecf9d..9fbdcbe 100644
--- a/resources/pelias/dictionaries/libpostal/en/street_types.txt
+++ b/resources/pelias/dictionaries/libpostal/en/street_types.txt
@@ -14,3 +14,5 @@ beltway
!broadway|bdwy|bway|bwy|brdway
!esplanade|esp|espl
market
+
+!spr
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the acceptance-test query for “San Simeon Drive Desert Hot Springs CA 92240” and the git bisect result at parser commit a65218d347b682da291ee16b6f84ddf4aba4827a. Read resources/pelias/dictionaries/libpostal/en/street_types.txt and compare the proposed spr entry with the classification output. Done means explaining why the regression occurs and verifying the chosen fix against the shown baseline diff.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100