pelias / pelias/api

Utilize express routing to reduce reliance on predicates

Open
#995 0 comments 2 reactions 1 assignee View on GitHub

@trescube is already working on this.

Since Sep 19, 2017.

Q3-2017
Dominant language
JavaScript
Stars
259
Forks
168
Avg merge
6h 15m
Merged PRs (30d)
1

Description

The express framework allows middleware components to fast-forward to middleware further down the pipeline. Currently, controllers use predicates to skip execution which becomes very cumbersome and difficult to track. For example, an error condition in a sanitizer needs to be checked by everything whereas with express routing, everything in the middle could be skipped and execution could jump directly to output.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.